Ps: I'm not quite sure about this one, seems like returning a nil Block could be unexpected behaviour in a lot of places

same tbh, I think I created this issue due to some feedback somewhere, but I wish I had more context into why this should be switched from a panic. Its an unexpected state that means something is seriously wrong, so it feels like panicking is the appropriate thing to do.

I'll dig around and try to find the reason for this. We want to remove the ability to compute shares entirely from tendermint, and completely rely on the app for checking/generating it. In that case in particular, we want to panic if there isn't a hash already set in the block data.

I think changing this to return an error would be a mistake. Especially since in all use outside of tests that don't in the application, we should never reach the spot that is returning an error. In fact, it seems like a good thing to panic.

thanks for bring this to my attention @rahulghangas and sorry for not clearing out this issue sooner.

I think we should close this unmerged and close the issue as well.